Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - disable slug change check #762

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

mathiazom
Copy link
Contributor

@mathiazom mathiazom commented Oct 10, 2024

Time to kill some of my own darlings...

We are currently setting the slug field to read-only after publication and making sure that slugs of published documents are not changed.

I think it makes more sense, and avoids a lot of pain, to trust the user that a redirect will be created if the old slug should still work. If that later seems to not be the case, we can reintroduce these constraints.

@mathiazom mathiazom requested a review from anemne October 10, 2024 14:21
Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 2:39pm
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 2:39pm

Copy link
Contributor

@anemne anemne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea for now

@mathiazom mathiazom merged commit 9a105ee into v3 Oct 14, 2024
6 checks passed
@mathiazom mathiazom deleted the feat/v3-disable-slug-change-check branch October 14, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants